Attempt fix to #112 #113
Merged
Attempt fix to #112 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old tests didn't verify the signatures were produced and also assumed that signing config wasn't set up wherever you ran tests. Since I do use signed commits now for my own work, this was a bad assumption and made the tests fail locally. Now we check for either the signature to be present or that signing failed because no secret key was found. For disabling signing, we ensure that no signature was added to the commit.
When using git CLI, if you don't specify the initial branch for git init, it gives a warning about you not having specified a preference for what your initial branch should be.
Might regret this, but it's confusing to print out fatal errors here when we handle the result either way. It's normal that some of these value source's might fail, e.g. if your project isn't running from a Git repo.
Old behavior was to use the reference repo (usually the project's checkout repo) as a full remote that we would fetch from. However, Git has a more direct way to reference an existing repo, using `objects/info/alternates`. This mechanism will just let you reuse objects that already exist in the reference repo rather than fetching from the real remotes. So now only origin is a remote and we just try to reuse objects from the remote. This also simplifies things where we had to check if the branch we cared about existed. Now, we don't care and if the objects are relevant they get used and if not, it should be no harm, no foul. This will hopefully address the issue that reported in #112.
This is unnecessary for this plugin behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily covers an attempted fix for lighweight checkouts being used as references. Additionally, it tries to suppress more superfluous output from printing in the Gradle output.