-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grgit.branch.current() fails #229
Comments
Even we are facing the same issue. More details: |
The method |
I was under the mistaken assumption that my POMs were being published with static versions, but it seems the I'll push out a quick fix to cap the version so it doesn't include v5. But later today I'll figure out how to get static versions published again in the POM. |
Unfortunately nebula-maven-resolved-dependencies doesn't seem to put static versions into the POM of com.gradle-plugin-publish artifacts. It does affect everything I'm pushing to Bintray though. So we've been using super permissive dependency ranges out to everyone and now, people are being bit by a breaking change in JGit 5. This is a quick fix for #229 to just make the JGit dependency static.
Unfortunately nebula-maven-resolved-dependencies doesn't seem to put static versions into the POM of com.gradle-plugin-publish artifacts. It does affect everything I'm pushing to Bintray though. So we've been using super permissive dependency ranges out to everyone and now, people are being bit by a breaking change in JGit 5. This fixes for #229 to just make the JGit dependency static.
Unfortunately nebula-maven-resolved-dependencies doesn't seem to put static versions into the POM of com.gradle-plugin-publish artifacts. It does affect everything I'm pushing to Bintray though. So we've been using super permissive dependency ranges out to everyone and now, people are being bit by a breaking change in JGit 5. This fixes for #229 to just make the JGit dependency static.
I'm gong to have to head off to work, but if this build succeeds there will be a 2.2.1-rc.2 which should statically include JGit 4.11. If that doesn't work or if you need something sooner, you'll need to use the buildscript block to force a specific JGit version to be pulled in. I still plan to get a final fix out tonight. |
Thank you for the quick fix! I was building a project last night that suddenly wouldn't build for a release I needed today... I love the simplicity of this plugin. Keep up the great work! :) |
I'll leave this open until I publish 2.2.1 final (see note in #234 for why that hasn't happened yet). Plan is to wrap this up tonight. |
2.2.1 is out now |
Since this morning (2018-05-31T06:11:28.179Z) my build fails on "grgit.branch.current()" with the message:
The call to FileRepository.getRef() is on line 44 of org.ajoberstar.grgit.service.BranchService (current master).
Interestingly enough in this particular build 'org.eclipse.jgit' and 'org.eclipse.jgit.ui' have been update to update version '5.0.0.201805151920-m7'.
I have this issue with grgit version 2.1.1 aswell as 2.2.0.
The text was updated successfully, but these errors were encountered: