Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better rename tracking in ShowOp #273

Closed
mithomas opened this issue Feb 15, 2019 · 2 comments
Closed

Better rename tracking in ShowOp #273

mithomas opened this issue Feb 15, 2019 · 2 comments
Labels
enhancement
Milestone
3.1.0

Comments

@mithomas
Copy link
Contributor

Currently the CommitDiff returned by ShowOp does return a list of renames, which contains the new file name (as indicated by renamed: entriesByType[ChangeType.RENAME].collect { it.newPath }).

From my perspective it would be a good idea to either change renamed to a map from old to new filename or, to not break the API, to introduce a new field containing this information.

I'd be happy to provide a PR, if this is something accepted - what do you think?
@ajoberstar
Copy link
Owner

@mithomas Yes, this would be a nice change to the API. Let's keep it backwards compatible, and so add a new field, maybe renamedOldToNew or something similar. Would definitely welcome a PR! Sorry for the delayed reponse.

mithomas added a commit to mithomas/grgit that referenced this issue Mar 18, 2019
@mithomas
Added rename tracking to ShowOp (ajoberstar#273).
365943b
ajoberstar added a commit that referenced this issue Mar 22, 2019
@ajoberstar
Merge pull request #281 from mithomas/master
b2c1fec 
Added rename tracking to ShowOp (#273).
@ajoberstar ajoberstar added this to the 3.1.0 milestone Mar 23, 2019
@ajoberstar
Copy link
Owner

Fixed by #281.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@ajoberstar @mithomas