Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --contains flag for branch list #105

Merged
merged 2 commits into from
Mar 21, 2016
Merged

Implement --contains flag for branch list #105

merged 2 commits into from
Mar 21, 2016

Conversation

nesterov-n
Copy link

Hello.

I implemented '--contains' param for branch list command.

@ajoberstar ajoberstar added this to the 1.6.0 milestone Mar 20, 2016
@ajoberstar
Copy link
Owner

Thanks for putting this together. One change I think would be benficial is making contains an Object, so it could be a Grgit Commit instance or some other representation of a revision. If you look at TagAddOp I'm using that pattern for the pointsTo object (and use the toRevisionString method to convert it back to a string).

@nesterov-n
Copy link
Author

@ajoberstar Done

ajoberstar added a commit that referenced this pull request Mar 21, 2016
Implement --contains flag for branch list
@ajoberstar ajoberstar merged commit 8fcad92 into ajoberstar:master Mar 21, 2016
@ajoberstar
Copy link
Owner

Great! Thanks again.

@nesterov-n nesterov-n deleted the features/contains branch March 22, 2016 10:13
@nesterov-n
Copy link
Author

@ajoberstar When do you plan release new version of your lib? I really need this feature for my build system :)

@ajoberstar
Copy link
Owner

1.6.0-rc.1 is out now

@nesterov-n
Copy link
Author

Great! Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants