Remove custom exception type #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since JGit's exceptions are more information, all uses of custom exception types were removed and JGit's are allowed to bubble up, when there isn't any explicit handling needed. This is not quite what the original requester in #146 had in mind, but this seems like a better experience when something fails. For someone trying to catch excpetions, they'll probably need to catch raw Exception. It was unlikely trying to wrap them all was going to be successful anyway.
|
SonarQube analysis reported 1 issue Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since JGit's exceptions are more information, all uses of custom
exception types were removed and JGit's are allowed to bubble up, when
there isn't any explicit handling needed.
This is not quite what the original requester in #146 had in mind, but this
seems like a better experience when something fails. For someone trying
to catch excpetions, they'll probably need to catch raw Exception. It
was unlikely trying to wrap them all was going to be successful anyway.