New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when reverting a commit results in a failingResult #247

Merged

ajoberstar merged 1 commit into ajoberstar:master from gavinbunney:revert-failure-fix

Jul 3, 2018

gavinbunney commented Jul 3, 2018

When a JGitRevertCommand fails, then a null RevCommit is returned from the call method (see https://github.com/eclipse/jgit/blob/master/org.eclipse.jgit/src/org/eclipse/jgit/api/RevertCommand.java#L219).

This PR adds a check for any failure modes and throws an exception (message shamelessly taken from MergeOp)


          Fix issue when reverting a commit results in a failingResult

2371c97

Owner

ajoberstar commented Jul 3, 2018

Thanks! I'll get this merged in tonight.

ajoberstar merged commit 867b8be into ajoberstar:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet