Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consitient parameter naming #255

Merged

Conversation

marcinczapla
Copy link
Contributor

I've made the naming of the Credentials parameter consitient between open and clone methods.

@ajoberstar
Copy link
Owner

Thanks @marcinczapla. The consistency is a good improvement, however, since the old name wasn't deprecated, I don't want to remove it just yet.

You'll want to put a deprecated getter/setter in place (but still only have your new consistently named field).

Let me know if you have further questions/thoughts.

@ajoberstar
Copy link
Owner

Sorry for the delay, and thanks for the update! This will be in 3.0.

@ajoberstar ajoberstar merged commit 5766317 into ajoberstar:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants