You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think ReckonExtension.setDefaultInferredScope/1 could be overloaded to accept org.ajoberstar.reckon.core.Scope as well — unless this one is not supposed to be used somehow.
Overload seems fine to me. Personally think the need to do an import to get the enum approach to work is going to be more error prone than using the string.
I think
ReckonExtension.setDefaultInferredScope/1
could be overloaded to acceptorg.ajoberstar.reckon.core.Scope
as well — unless this one is not supposed to be used somehow.I'm currently using it like:
...but I think accepting the
enum
as well is better because using constant is less error prone, and can provide a (very) small performance advantage.The text was updated successfully, but these errors were encountered: