-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle Plugin as composite build breaks reckon #74
Comments
I haven't used composite builds much myself, but I tried to reproduce this quickly and it seemed to reckon each project correctly. It's possible you're just running into some new validation in reckon 0.5.0. To help figure out if this is tied to composite builds or 0.5.0, can you provide some more information?
|
gradle version: 4.6 plugin build.gradle:
git describe plugin: 1.3.0 gradle command: cmd fail evaluating the plugin project. The plugin applies the reckon plugin to the main project, so at the point of failure, reckon isn't even configured on the main project. However I was able to reproduce the issue by adding reckon to mainProject |
I wonder if it has to do with it being a plugin project. I'll try to reproduce it that way. Thanks for the info! |
Ah, I think I see the issue now... Both projects are reading the I'll try a few things to see if there's a way to do this. May need to try to detect whether your part of a composite build within the plugin. |
FYI, I expect you'll run into the lack of composite build support for plugins once you get past this. |
Composite builds that include multiple builds that use reckon can run into unexpected behavior, because any reckon.* props passed in on the command line are used by all builds. This can cause it to try to increment a version incorrectly. The new behavior makes it so that only the main build within a composite will actually respect the gradle properties. This does imply that you can't really release a version of an included build, but the expectation is that that's not what anyone would intend to do. That could be proven wrong, but it would require something more involved to support. This fixes #74.
Composite builds that include multiple builds that use reckon can run into unexpected behavior, because any reckon.* props passed in on the command line are used by all builds. This can cause it to try to increment a version incorrectly. The new behavior makes it so that only the main build within a composite will actually respect the gradle properties. This does imply that you can't really release a version of an included build, but the expectation is that that's not what anyone would intend to do. That could be proven wrong, but it would require something more involved to support. This fixes #74.
You can test out 0.6.0-rc.1 to see if it solves your issue. |
Thanks for the speedy fix! Thanks for the head up on the composite issue. I remember running into it about a year ago, I we have some custom logic to make it work (though I can't remember the details, I would need to look at the code) |
I recently migrated to reckon from you're older plugin and am running into an issue.
I have a gradle plugin that I include in a composite build
Both of these repos (plugin & main project) use reckon for version inferencing. However when I try and release the main project, I get the following error b/c reckon is "reckoning" the gradle plugin.
Cannot re-release a final version 1.3.0 as a pre-release: 2.0.0-beta.1
I've tried running the task with the
:
prefix to only run it for the root project w/ no luckThe text was updated successfully, but these errors were encountered: