Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when repo is not clean #91

Closed
ajoberstar opened this issue Jun 16, 2018 · 4 comments
Closed

Better error message when repo is not clean #91

ajoberstar opened this issue Jun 16, 2018 · 4 comments

Comments

@ajoberstar
Copy link
Owner

When trying to release a significant version and have a dirty repo, you get an exception, which explains this, but doesn't say what files are in an unclean state. Should include a formatted version of the status output to make this easier to use.

@ajoberstar ajoberstar modified the milestone: 0.8.0 Jul 4, 2018
@ajoberstar
Copy link
Owner Author

Not entirely clear where to put this code-wise. We don't want to do that formatting when its not needed, and we don't know we need it until long after the inventory was calculated.

Dropping this idea for now.

@ajoberstar
Copy link
Owner Author

As evidenced by #95, there would be benefit in improving the message.

@ajoberstar ajoberstar reopened this Jul 10, 2018
@sschuberth
Copy link

Improving the message to actually state what is considered "unclean" would be very welcomed. In my case it was git-submodules for which I had configured ignore = untracked which apparently is not honored by JGit. Not very obvious.

@ewallerman
Copy link

Running CI in Jenkins that cleans the workspace when syncing from the git repo, try to build a final release but got
"Caused by: java.lang.IllegalStateException: Cannot release a final or significant stage without a clean repo. at org.ajoberstar.reckon.core.Reckoner.reckon(Reckoner.java:54)"
git status on commandline "working tree clean"
Could not find the reason for the exception.
Improving the message to actually state what is considered "unclean" would be very welcomed.

ajoberstar added a commit that referenced this issue Apr 22, 2023
ajoberstar added a commit that referenced this issue Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants