-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise lifetime and reference handling for child objects inside PdfDocument. #47
Comments
Revised bookmarks, metadata, permissions, and signatures collections in time for 0.7.20. |
Additionally, |
The separation of |
On reflection, better to save a potentially breaking change like this for 0.8.0. This means that fleshing out the implementation of |
Corrected a few typos in examples. Added |
Added bindings for all remaining |
Completed WASM bindings for release 0.7.21. |
Fixed a bug in the WASM implementation of |
Removed unnecessary |
Moved commentary about interface differences between native and WASM builds out of README.md into examples/README.md. |
Improved implementation of |
Changed return type of |
Updated |
#67 deprecates This would require this issue to not only split |
Added |
Completing implementation of reading form fields in #76 allows us to proceed with crate version 0.8.0. |
Implemented split of |
Early experiments with splitting (Interior mutability in |
Clearly, splitting |
Released as crate version 0.8.0. |
As of 0.7.19, the child objects inside
PdfDocument
are created and returned using a variety of different approaches:PdfDocument::bookmarks()
,PdfDocument::metadata()
,PdfDocument::permissions()
,PdfDocument::signatures()
.new()
constructor, then hand out mutable or immutable references to that owned collection as necessary, e.g.PdfDocument::attachments()
,PdfDocument::attachments_mut()
.PdfPages
, which supports both immutable and mutable access but does not distinguish between mutable and immutable references, instead handing out a new object instance each time it is called fromPdfDocument::pages()
.Standardise the approach. All collections should create private owned collection instances inside the containing object as part of the object's
new()
constructor, function, then hand out mutable or immutable references as necessary. New object instances should never be handed out.The text was updated successfully, but these errors were encountered: