Skip to content
This repository has been archived by the owner on Jan 5, 2022. It is now read-only.

Issue #17 - breaking changes on master #18

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Issue #17 - breaking changes on master #18

merged 4 commits into from
Dec 17, 2021

Conversation

cowboy-bebug
Copy link
Contributor

@cowboy-bebug cowboy-bebug commented Dec 17, 2021

Following what's mentioned in paritytech/substrate#10403,

  • Default is removed for PlayerStruct (to avoid deriving default values for T::AccountId) and
  • OptionQuery is used for BracketIndexKeyMap and BracketKeyValueMap storage items

Changes (in the order of commits):

  • 3b64a3e: run cargo fmt
  • 293c850: peg / freeze upstream dependencies at a revision
    • specifying version seems a little bit meaningless for us since we're pointed directly to the latest upstream master
    • instead, using rev to peg at a commit hash
    • chosen this commit, paritytech/substrate@3dc9842, as it was the highest commit without breaking changes
  • c18cbba: point to the commit of the breaking changes, paritytech/substrate@55cd07a, and fix any errors
    • removed deriving Default for PlayerStruct as mentioned in Remove Default bound for AccountId paritytech/substrate#10403
    • use OptionQuery for the storage items dealing with T::AccountId
    • add the recently introduced MaxConsumers for mock (as empty for now)
    • small refactor for fn pop() since the storage items now return Option
  • 18d608b: point to the latest master

Closes #17.

@cowboy-bebug cowboy-bebug marked this pull request as draft December 17, 2021 04:53
@cowboy-bebug cowboy-bebug marked this pull request as ready for review December 17, 2021 05:38
@darkfriend77 darkfriend77 self-requested a review December 17, 2021 15:00
Copy link
Contributor

@darkfriend77 darkfriend77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@darkfriend77 darkfriend77 merged commit b9673a1 into ajuna-network:master Dec 17, 2021
@cowboy-bebug cowboy-bebug deleted the 17/peg-upstream-dependencies branch December 17, 2021 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pallet_matchmaker broken on latest master of substrate
2 participants