Don't mutate a schema with a transform keyword while compiling it. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
reviewed
May 4, 2021
src/definitions/transform.ts
Outdated
| @@ -54,13 +54,15 @@ function _getDef(): CodeKeywordDefinition { | |||
|
|
|||
| function transformExpr(ts: string[]): Code { | |||
| if (!ts.length) return data | |||
| const t = ts.pop() as string | |||
There was a problem hiding this comment.
I suggest to pass tNames.slice() above rather than to copy on every iteration... Mostly because to is clearer what is going on.
|
Thank you - good catch - see the comment. |
|
This should fix everything discussed on #152. |
|
sorry - forgot about it... Better late than never |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=> If the schema is compiled twice, the second validator function won't work properly since the transform array will have been emptied.