-
-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _opts property type in Ajv.Ajv #1262
Add _opts property type in Ajv.Ajv #1262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t it be the same interface as for Options?
@epoberezkin |
Self-resolved. |
…to refactor-opt-object-type
I am thinking it may be best to wait a bit until v7 is released in a week or so... |
It might be important to access this property though - defaultMeta is not the same as meta, so it should be added too. Merging it. |
@epoberezkin @b4h0-c4t is right now it's undocumented and i don't see any recommendation for using it other than from the old v5 docs, but it seems to work if you set it in the constructor as long as you add the relevant metaSchema straight afterwards. Maybe i'm missing something important though. |
What issue does this pull request resolve?
resolve #1253 issue.
What changes did you make?
Add type declaration Ajv.Ajv._opt
Is there anything that requires more attention while reviewing?
The reason why I set any type is other any object( ex.
_metaOpts
) could not compatible with detailed objects.