resolve references before validating the discriminator #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
reviewed
Nov 12, 2021
|
Great - added some comments, it’s quite a common request. please also update the docs to mention that single $refs (that is, without siblings) are now supported as well. |
|
CI runs a bit more combinations of options than run locally by default, it uses: AJV_FULL_TEST=true npm test Maybe that’s the difference? See the test output in CI. |
|
So you can try locally with the same env variable |
epoberezkin
reviewed
Nov 21, 2021
|
Thanks for the change, it definitely improves the usability of discriminator - only supporting inlined schema was an annoying restriction... There couple of comments I wanted to amend - let me know if it's ok I do it? |
|
Sure, feel free. |
epoberezkin
reviewed
Jan 15, 2022
epoberezkin
reviewed
Jan 15, 2022
epoberezkin
reviewed
Jan 15, 2022
epoberezkin
reviewed
Jan 15, 2022
epoberezkin
reviewed
Jan 15, 2022
epoberezkin
reviewed
Jan 15, 2022
epoberezkin
reviewed
Jan 15, 2022
epoberezkin
reviewed
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1554
What issue does this pull request resolve?
What changes did you make?
Is there anything that requires more attention while reviewing?