-
-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
special case empty object for jtd #2158
Merged
epoberezkin
merged 3 commits into
ajv-validator:master
from
erikbrinkman:jtd-empty-discriminant-unions
Jan 2, 2023
Merged
special case empty object for jtd #2158
epoberezkin
merged 3 commits into
ajv-validator:master
from
erikbrinkman:jtd-empty-discriminant-unions
Jan 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbrinkman
force-pushed
the
jtd-empty-discriminant-unions
branch
from
November 14, 2022 05:04
ff529be
to
87dadd5
Compare
Great, thank you! |
epoberezkin
approved these changes
Nov 20, 2022
It failed when merging master in - will check later what happened… |
The build failure is
which seems unrelated to this merge. Seems like a versioning issue, but probably worth investigating :/ |
This was referenced Jan 30, 2024
This was referenced Sep 12, 2024
This was referenced Sep 14, 2024
This was referenced Sep 17, 2024
This was referenced Sep 19, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
fixes #2123
What changes did you make?
In short, this special cases empty objects since they have special meaning due to the way typescripts type system works. I'll leave more detail in the issue.
Is there anything that requires more attention while reviewing?
I did some various "clean up" to JTD Schema as well, but the substantiative change is special casing that type and adding tests. I think the test coverage is pretty solid (although clearly not perfect) so I wouldn't be too worries.