[DNM] RFCS: draft of transactional schema changes

.gitattributes

@@ -1,2 +1,3 @@
 *.pb.* -diff
 *.eg.go -diff
+DEPS.bzl -diff

.github/CODEOWNERS

@@ -21,6 +21,7 @@
 /pkg/sql/sem/builtins/       @cockroachdb/sql-api-prs
 
 /pkg/cli/                    @cockroachdb/cli-prs
+/pkg/server/                 @cockroachdb/cli-prs
 
 /pkg/ccl/backupccl/          @cockroachdb/bulk-prs
 /pkg/ccl/importccl/          @cockroachdb/bulk-prs
@@ -32,6 +33,9 @@
 /pkg/geo                     @cockroachdb/geospatial
 
 /pkg/ui/                     @cockroachdb/admin-ui-prs
-/pkg/ui/embedded.go
-/pkg/ui/src/js/protos.d.ts
-/pkg/ui/src/js/protos.js
+/pkg/ui/embedded.go          @cockroachdb/admin-ui-prs
+/pkg/ui/src/js/protos.d.ts   @cockroachdb/admin-ui-prs
+/pkg/ui/src/js/protos.js     @cockroachdb/admin-ui-prs
+
+/docs/generated/http         @cockroachdb/http-api-prs
+/pkg/cmd/docgen/http.go      @cockroachdb/http-api-prs

.gitignore

@@ -32,3 +32,6 @@ customenv.mk
 # Generated files containing include paths.
 zcgo_flags*.go
 build/Railroad.jar
+
+# Bazel generated symlinks
+/bazel-*

.gitmodules

@@ -4,22 +4,9 @@
 [submodule "c-deps/jemalloc"]
 	path = c-deps/jemalloc
 	url = https://github.com/cockroachdb/jemalloc.git
-[submodule "c-deps/rocksdb"]
-	path = c-deps/rocksdb
-	url = https://github.com/cockroachdb/rocksdb.git
-[submodule "c-deps/snappy"]
-	path = c-deps/snappy
-	url = https://github.com/cockroachdb/snappy.git
-	ignore = untracked
 [submodule "c-deps/protobuf"]
 	path = c-deps/protobuf
 	url = https://github.com/cockroachdb/protobuf.git
-[submodule "c-deps/cryptopp"]
-	path = c-deps/cryptopp
-	url = https://github.com/cockroachdb/cryptopp.git
-[submodule "c-deps/googletest"]
-	path = c-deps/googletest
-	url = https://github.com/cockroachdb/googletest
 [submodule "pkg/ui/yarn-vendor"]
 	path = pkg/ui/yarn-vendor
 	url = https://github.com/cockroachdb/yarn-vendored

AUTHORS

@@ -20,8 +20,10 @@
 Aaditya Sondhi <aadityas@cockroachlabs.com>
 Aaron Blum <aaron@cockroachlabs.com>
 Aaron Dunnington <aaron.dunnington@gmail.com> aarondunnington <aaron.dunnington@gmail.com>
+Aaron Zinger <zinger@cockroachlabs.com>
 Aayush Shah <aayush.shah15@gmail.com> <@cockroachlabs.com>
 Abby Hersh <abby@cockroachlabs.com>
+Abbey Russell <abbey@cockroachlabs.com> Abigail Russell <abigail.michelle.russell@gmail.com> <amruss@mit.edu>
 Abhishek Madan <abhi.madan01@gmail.com> <abhimadan@users.noreply.github.com> <abhishek@cockroachlabs.com> Abhemailk abhi.madan01@gmail.com <abhishek@cockroachlabs.com>
 Abhishek Soni <abhishek.rocks26@gmail.com>
 Abhishek Saha <as1695@scarletmail.rutgers.edu> AbhishekSaha <as1695@scarletmail.rutgers.edu>
@@ -33,6 +35,7 @@ Adam Yao <adam.yao.qinglin@gmail.com>
 Aditya Maru <adityamaru@gmail.com> <@cockroachlabs.com>
 Aid Idrizović <idrizovicaid@gmail.com>
 Ajaya Agrawal <ajku.agr@gmail.com>
+Alan Acosta <acostas.alan@gmail.com>
 Alex Gaynor <alex.gaynor@gmail.com>
 Alex Lunev <lunevalex@gmail.com> <alexl@cockroachlabs.com>
 Alex Robinson <alexdwanerobinson@gmail.com> <arob@google.com> <@cockroachlabs.com>
@@ -127,6 +130,7 @@ Harshit Chopra <harshit@squareup.com>
 Hayden A. James <hayden.james@gmail.com>
 Helen He <helenhe.mit@gmail.com> <@cockroachlabs.com>
 Ibrahim AshShohail <ibra.sho@gmail.com>
+Ian Evans <ian@cockroachlabs.com>
 Igor Kharin <igorkharin@gmail.com>
 il9ue <oodanq@gmail.com>
 Irfan Sharif <irfanmahmoudsharif@gmail.com> irfan sharif <irfanmahmoudsharif@gmail.com> <@cockroachlabs.com>
@@ -203,6 +207,7 @@ Manik Surtani <manik@squareup.com> <manik@surtani.org>
 Marc Berhault <marc.berhault@gmail.com> marc <marc@cockroachlabs.com> MBerhault <marc.berhault@gmail.com>
 Marcus Gartner <marcus@cockroachlabs.com> <magartner@gmail.com>
 Marcus Westin <marcus.westin@gmail.com>
+Marius Posta <marius@cockroachlabs.com>
 Marko Bonaći <mbonaci@users.noreply.github.com>
 Martin Bertschler <mbertschler@gmail.com>
 Masha Schneider <masha@cockroachlabs.com> <mshv14282@gmail.com>
@@ -213,9 +218,12 @@ Matthew O'Connor <matthew@squareup.com> <matthew.t.oconnor@gmail.com>
 Max Lang <max@cockroachlabs.com> <maxwell.g.lang@gmail.com>
 Mayank Oli <mayankoli96@gmail.com>
 mbonaci <mbonaci@gmail.com>
+Miguel Novelo <miguel.novelo@digitalonus.com> <jmnovelov@gmail.com>
 mike czabator <michaelc@cockroachlabs.com>
 Mo Firouz <mofirouz@mofirouz.com>
 Mohamed Elqdusy <mohamedelqdusy@gmail.com>
+Monica Xu <monicax@cockroachlabs.com> <mokaixu@gmail.com>
+Namrata Kodali <namrata@cockroachlabs.com> <namrata.kodali@gmail.com>
 Nate Stewart <nathaniel.p.stewart@gmail.com> Nate <nathaniel.p.stewart@gmail.com> <nate@cockroachlabs.com>
 Nathan Johnson <njohnson@ena.com>
 Nathan VanBenschoten <nvanbenschoten@gmail.com> <@cockroachlabs.com>

BUILD.bazel

@@ -0,0 +1,110 @@
+load("@bazel_gazelle//:def.bzl", "gazelle")
+
+# The following directives inform gazelle how to auto-generate BUILD.bazel
+# files throughout the repo. By including them here, we can run gazelle using
+# `bazel run //:gazelle` instead of invoking gazelle directly.
+#
+# NB: Be sure to re-generate BUILD.bazel files if any of the directives below
+# are changed.
+
+# Define the gazelle prefix and what the autogenerated BUILD files should be
+# named as.
+#
+# gazelle:prefix github.com/cockroachdb/cockroach
+# gazelle:build_file_name BUILD.bazel
+
+# We disable protobuf generation for our dependencies
+#
+# gazelle:proto disable_global
+
+# Gazelle is unable to resolve this specific package.
+#
+# TODO(irfansharif): I'm not sure why this is. Is it because it's a proto only
+# package?
+#
+# gazelle:resolve go github.com/grpc-ecosystem/grpc-gateway/internal //vendor/github.com/grpc-ecosystem/grpc-gateway/internal
+
+# We exclude a few things from gazelle consideration:
+# - The protobuf C dependency, it's are already bazel-ified, lest we overwrite
+#   those build files.
+# - The artifacts directory
+# - All checked-in autogenerated files (they'll get autogenerated on the fly
+#   through bazel).
+# - A testdata "repo" that looks like a go package, but isn't
+#   (testdata/src/example.com)
+#
+# gazelle:exclude c-deps/protobuf
+# gazelle:exclude artifacts
+# gazelle:exclude **/zcgo_flags.go
+# gazelle:exclude **/zcgo_flags_*.go
+# gazelle:exclude **/*.og.go
+# gazelle:exclude **/*.eg.go
+# gazelle:exclude pkg/sql/parser/sql.go
+# gazelle:exclude pkg/sql/opt/rule_name_string.go
+# gazelle:exclude pkg/sql/opt/rule_name_string.go
+# gazelle:exclude pkg/cmd/prereqs/testdata
+
+# Generally useful references:
+#
+#   https://docs.bazel.build/versions/master/user-manual.html
+#   https://docs.bazel.build/versions/master/guide.html
+
+# TODO(irfansharif): Today we let bazel take over the vendor directory and
+# define each vendored dependency as a bazel target. We should be able to have
+# bazel ignore all of vendor/ and create those dependencies on the fly.
+# Deleting the vendor directory and running `bazel run //:gazelle` shows what
+# that would look like (though that doesn't quite work yet).
+
+# TODO(irfansharif): Document a few usage patterns for bazel and how to
+# understand all the autogen stuff. Probably as a tech note. Here are a few
+# short hands I've used so far:
+#
+#   bazel test //pkg/kv/kvserver/concurrency/...
+#   bazel test //pkg/kv/kvserver:all --test_cache_results=no --test_output=all
+#   bazel test --features race //pkg/kv/kvserver/concurrency/... --test_output=all \
+#     --test_arg='-test.v' --test_arg='-show-logs' --test_filter='TestBTreeClone.*' \
+#     --run_under='stress -maxtime=120s' --cache_test_results=no
+#   bazel build //pkg/sql/opt
+#   bazel build //pkg/sql/opt:all
+#   bazel build //pkg/sql/colexec:gen-exec
+#   bazel build //pkg/cmd/cockroach-short
+#   bazel build //:libjemalloc
+#   bazel query //pkg/sql/colexec:all
+#   bazel run //:gazelle
+#   bazel run //pkg/cmd/cockroach-short -- demo
+#   bazel run //pkg/sql/opt/optgen/cmd/langgen -- -h
+#   bazel run //:gazelle -- update-repos -from_file=go.mod -to_macro=DEPS.bzl%go_deps
+#
+# The //<stuff> names can also be fully qualified using @cockroach, and that
+# appears in certain parts of the codebase/elsewhere. Specifically it'll look
+# like:
+#
+#   bazel build @cockroach//pkg/cmd/cockroach-short
+#
+# TODO(irfansharif): We should define shorthands for all of the above. See
+# https://docs.bazel.build/versions/master/skylark/tutorial-custom-verbs.html
+
+# TODO(irfansharif): The way we currently generate code through bazel, that
+# code is only available within the bazel sandbox. Bazel ignores all
+# the pre-generated code that is already checked into the codebase (through
+# `make generate`/etc.) through the exclude directives above. It's generating
+# everything on the fly.
+#
+# As we move towards bazel, we'll want to introduce a mechanism that implants
+# the generated code within the sandbox placing them "back into" the
+# appropriate packages. This is to ensure we don't break existing IDEs and code
+# editors which rely on files existing in the same package itself (as opposed
+# to the sandbox). This way we could continue checking in auto-generated code.
+# We should provide a bazel alternative for `make generate` that does this very
+# same thing. See [1], this is a long standing issue for folks using using Go,
+# bazel, and autogenerated code.
+#
+# [1]: https://github.com/bazelbuild/rules_go/issues/512.
+
+# TODO(irfansharif): We'll need to pin toolchains somewhere to make sure
+# everything below works as expected.
+
+gazelle(
+    name = "gazelle",
+    prefix = "github.com/cockroachdb/cockroach",
+)