darker fails with git error

[DeinAlptraum]

I just installed darker (python-darker package on Arch Linux) and get an error immediately when running it on a file:

/data/.../python/clang >>> darker cindex.py
Traceback (most recent call last):
  File "/usr/bin/darker", line 8, in <module>
    sys.exit(main_with_error_handling())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/darker/__main__.py", line 633, in main_with_error_handling
    return main()
           ^^^^^^
  File "/usr/lib/python3.12/site-packages/darker/__main__.py", line 570, in main
    if git_is_repository(common_root):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/darker/git.py", line 40, in git_is_repository
    lines = git_check_output_lines(
            ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/darkgraylib/git.py", line 244, in git_check_output_lines
    return _git_check_output(
           ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/darkgraylib/git.py", line 276, in _git_check_output
    return check_output(  # nosec
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git', 'rev-parse', '--is-inside-work-tree']' returned non-zero exit status 128.

although

/data/.../python/clang >>> git rev-parse --is-inside-work-tree
true

so no problems there. No virtual environment used. Help would be appreciated!

[DeinAlptraum]

Some additional information: I modified the module to print the error and got this:

fatal: detected dubious ownership in repository at '/data/shared/programming/repos/llvm-project'
To add an exception for this directory, call:

        git config --global --add safe.directory /data/shared/programming/repos/llvm-project

There is already an exception on that directory, exectuing this code snippet changes nothing.

Removing the env=make_git_env() argument in the subprocess.check_output call allows this to pass

[akaihola]

Hi @DeinAlptraum, thanks for your report! I'm trying to fix this issue in akaihola/darkgraylib#74. To test whether it helps, first install Darker and then on top of it:

pip install darker@git+https://github.com/akaihola/darker@master
pip install darkgraylib@git+https://github.com/akaihola/darkgraylib@git-dubious-ownership

I also invited you as a collaborator on Darkgraylib. Feel free to review akaihola/darkgraylib#74!