Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Black >= 21.7b1.dev9 #183

Closed
wants to merge 5 commits into from

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Aug 31, 2021

Duplicate of #189.

@akaihola akaihola added the bug Something isn't working label Aug 31, 2021
@akaihola akaihola added this to the 1.3.0 milestone Aug 31, 2021
@akaihola akaihola self-assigned this Aug 31, 2021
@akaihola akaihola mentioned this pull request Aug 31, 2021
9 tasks
@akaihola akaihola changed the title Fix compatibility with Black >= 21.8b0 Fix compatibility with Black >= 21.7b1.dev9 Sep 2, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 3, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.79%.

Quality metrics Before After Change
Complexity 3.91 ⭐ 3.85 ⭐ -0.06 👍
Method Length 68.75 🙂 75.25 🙂 6.50 👎
Working memory 6.59 🙂 7.59 🙂 1.00 👎
Quality 75.95% 73.16% 🙂 -2.79% 👎
Other metrics Before After Change
Lines 171 180 9
Changed files Quality Before Quality After Quality Change
src/darker/black_diff.py 75.95% ⭐ 73.16% 🙂 -2.79% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@akaihola akaihola added the duplicate This issue or pull request already exists label Sep 3, 2021
@akaihola akaihola closed this Sep 3, 2021
@akaihola akaihola deleted the black-get_python_files-compatibility branch September 10, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
Development

Successfully merging this pull request may close these issues.

2 participants