Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black required versions #190

Merged
merged 2 commits into from
Sep 4, 2021
Merged

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Sep 4, 2021

There were two issues with Black versions:

  1. with current Black, Mypy shouldn't ignore extra call arguments for black.files.gen_python_files() (see Fix gen_python_files usage for black>=21.7b1.dev9 #189), but we have to make sure a recent enough Black is used when running tests
  2. Black < 21.5b1 are incompatible with at least to recently added features, so the minimum required Black version had to be bumped

@akaihola akaihola added bug Something isn't working CI labels Sep 4, 2021
@akaihola akaihola added this to the 1.3.0 milestone Sep 4, 2021
@akaihola akaihola self-assigned this Sep 4, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 4, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 3.83 ⭐ 3.83 ⭐ 0.00
Method Length 74.75 🙂 74.75 🙂 0.00
Working memory 6.74 🙂 6.74 🙂 0.00
Quality 75.51% 75.51% 0.00%
Other metrics Before After Change
Lines 175 175 0
Changed files Quality Before Quality After Quality Change
src/darker/black_diff.py 75.51% ⭐ 75.51% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@akaihola akaihola merged commit 1a1c09f into master Sep 4, 2021
@akaihola akaihola deleted the update-black-required-versions branch September 4, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
Development

Successfully merging this pull request may close these issues.

1 participant