Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a CI test against Black main branch #284

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

akaihola
Copy link
Owner

Fixes #186.

@yoursvivek would you be able to review this? Would you accept an invitation as a collaborator on this repository?

@akaihola akaihola added the CI label Feb 12, 2022
@akaihola akaihola added this to the 1.4.1 milestone Feb 12, 2022
@akaihola akaihola self-assigned this Feb 12, 2022
@akaihola akaihola force-pushed the test-against-dependencies-master branch from 7f2ddbd to 9504cdf Compare February 12, 2022 12:57
@akaihola akaihola force-pushed the test-against-dependencies-master branch from ccc622c to 38917e3 Compare February 12, 2022 20:00
@akaihola akaihola merged commit a71f913 into master Feb 12, 2022
Copy link
Collaborator

@yoursvivek yoursvivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing post merge, but change looks good to me.

Would you accept an invitation as a collaborator on this repository?

I'll be glad to help out. Count me in.

@akaihola
Copy link
Owner Author

Yes @yoursvivek, I figured I just had to merge it in order to see whether a cron schedule workflow runs on master. I tried to schedule it for Saturdays at 20:05 UTC (ten minutes ago), but it didn't run. I wonder why.

But anyway, the "future" test also runs as part of pull requests, and that seems to work fine.

@akaihola akaihola deleted the test-against-dependencies-master branch February 12, 2022 20:17
@akaihola
Copy link
Owner Author

Oh cool, now the cron workflow actually ran and succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Changes in Black internals may break Darker
2 participants