Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to pin reformatters/linters in pre-commit configuration #434

Merged
merged 6 commits into from
Dec 28, 2022
Merged

Document how to pin reformatters/linters in pre-commit configuration #434

merged 6 commits into from
Dec 28, 2022

Conversation

akaihola
Copy link
Owner

Fixes #426.

@akaihola akaihola added the documentation Improvements or additions to documentation label Dec 26, 2022
@akaihola akaihola added this to the 1.6.1 milestone Dec 26, 2022
@akaihola akaihola self-assigned this Dec 26, 2022
@akaihola
Copy link
Owner Author

Could one of you review this addition to documentation @wpnbos @k-dominik @victorcui96 @jedie @leej3? Thanks!

k-dominik
k-dominik approved these changes Dec 27, 2022
View reviewed changes
Copy link

@k-dominik k-dominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to the docs (and darker in general) is highly appreciated :)! I definitely know how to pin things after reading it.

The only thing that I noticed are the different indentation sizes/styles used in different portions of the Readme.

@akaihola
Copy link
Owner Author

@k-dominik, by different indentations, are you referring to YAML snippets?

@akaihola
Copy link
Owner Author

I now unified YAML formatting in README.rst.

@akaihola akaihola force-pushed the doc-pre-commit-black-version branch 2 times, most recently from 95c07e4 to 6c850ec Compare December 28, 2022 16:43
@akaihola akaihola merged commit bb4c1e5 into master Dec 28, 2022
@akaihola akaihola deleted the doc-pre-commit-black-version branch December 28, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-dominik k-dominik k-dominik approved these changes

Assignees

@akaihola akaihola

Labels
documentation Improvements or additions to documentation
Projects
Darker and Graylint development
Archived in project
Milestone
Darker 1.6.1
Development

Successfully merging this pull request may close these issues.

Document how to specify Black version when using a pre-commit hook
2 participants
@akaihola @k-dominik