Allow hyphens for option keys in pyproject.toml
#503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dwt would you be able to review this pull request? Can I invite you as a project collaborater and assign reviewing to you? |
akaihola
force-pushed
the
pyproject-hyphens
branch
3 times, most recently
from
fdb96fb
to
5a32119
Compare
These are the helpers functions for converting between hyphens and underscores, and for validating option keys.
akaihola
force-pushed
the
pyproject-hyphens
branch
from
5a32119
to
508eec1
Compare
|
Sure! Sorry, I was away on holidays for a few weeks, but now I'm back and I'd like to help. |
|
LGTM, you do the validation step (which is new afaik) and the conversion first, which should generate maximum backwards compatibility, while still generating strict errors. I like. :) To be frank, I'm not sure I understand the tests completely, but there seems to be a test that checks this scenario. So: LGTM? |
dwt
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502.
Also normalizes the
pyproject.tomldump seen in debug log level to always use hyphens instead of underscores in option keys.