Filter out unmodified files from list of changed files

[Svenito]

Adds an option --modified-only/-m to ignore renamed files from being checked.

Make the filter the default behaviour. Possibly add an option to include renamed files or not, depending on discussions below

Fixes #544

[akaihola]

Should this behavior maybe be the default? I mean, now that I think of it, if I just rename a source code file, why would I want the whole file to be reformatted in the same branch?

[Svenito]

I added it because you probably don’t want to check/format files unless their content has changed. Even when slowly phasing Black into a project.

I made it off by default because the original behaviour was to not exclude these files. If you are happy to make it default and remove the option, it’d be easier as the argument can be removed and the git diff always filtered. If that is desired behaviour that is.

Let me know what your thoughts are in this.

[Timple]

For me (user) it makes sense that this is the default!

[akaihola]

Thanks @Timple, and indeed @Svenito let's remove the option and hard-code this behavior as the default. I'll bump the major version number before including this in a release. Thanks!

[Svenito]

I made the changes in the last commit. Also added ‘A’ to the diff filter.

[akaihola]

@Svenito, could you update the unit tests? See test failures in test_git.py and test_main_revision.py. Let me know if you need me to clarify how the tests work.

[akaihola]

akaihola/darkgraylib#38 will be included in darkgraylib==1.1.0. So you could rebase on master, bump the dependency in setup.cfg, and after I've made the release we can rerun the tests here.

Sorry for the large refactoring by moving stuff into the new Darkgraylib library. And thanks for noticing and reacting to it!

[akaihola]

@Svenito unfortunately you'll need to do one more rebase on master before the tests have a chance to pass.

Also I'll wait for at least one more backwards incompatible change to land before merging this one and bumping the major version number. So probably later in the spring we'll get this one into a release.

Thanks a lot for your effort and sorry for the delay!

[Svenito]

Sounds good to me. No problem on the delay either.

[Svenito]

Hi, just wanted to check if there's a rough ETA on this patch making it in?

[akaihola]

Hi, just wanted to check if there's a rough ETA on this patch making it in?

I guess it's starting to be time to bring this in. There are no significant backwards-incompatible changes to bundle with it in v3.0.0, so maybe we'll just go with this one and risk needing to bump to v4 sooner than later.

So let me start prepare for a v3.0.0 release.

[akaihola]

Looks good to merge to me now. I don't understand why 13 CI jobs are always left unrun. But I did those lints locally, all is good.