Migrate cerberus to jsonschema #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rahulbhatvedekar, Thank you for the PR. There are 3 locations that need to be updated
|
Rahulbhatvedekar
force-pushed
the
migrate-cerberus-to-jsonschema
branch
from
76efcb0
to
135c00b
Compare
|
Version upgraded to 2.3.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building Docker images for cli-onboard (repository link), we have observed an increase in both the build time and the size of the images.
Before:
akamai/onboard amd64: 251MB
akamai/onboard arm64: 300MB
After:
akamai/onboard amd64: 169MB
akamai/onboard arm64: 160MB
To address this, we plan to use pre-built wheels. However, we encountered the following issues:
Missing Wheel for Cerberus 1.3.4:
As noted in this GitHub issue, the wheel for Cerberus 1.3.4 is missing on PyPI, and there is no ongoing maintenance for Cerberus. It's suggested to switch to python-jsonschema instead.
No Wheels for Pandas 2.1.2:
The required wheels for Pandas 2.1.2 are also unavailable.
Solution:
This PR replaces Cerberus with jsonschema. Additionally, to utilize wheels, it's necessary to upgrade to Pandas 2.2.2.