Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing on Windows by specifying encoding #83

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

step21
Copy link
Contributor

@step21 step21 commented Feb 7, 2022

In a windows environment, if the encoding is not specified, ASCII is expected. This creates errors when running setup.py when the README (or other files) contain emojis or other non-ascii characters. This fixes this at least for the README, not sure if there are other instances of this.

@akamhy akamhy added good first issue Good for newcomers bug Something isn't working and removed good first issue Good for newcomers labels Feb 7, 2022
@akamhy
Copy link
Owner

akamhy commented Feb 7, 2022

Thanks, I will add a build test to the CI.

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #83 (8a82381) into main (e0d2d8e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files           9        9           
  Lines         346      346           
=======================================
  Hits          343      343           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d2d8e...8a82381. Read the comment docs.

@akamhy akamhy mentioned this pull request Feb 7, 2022
@akamhy
Copy link
Owner

akamhy commented Feb 7, 2022

For future reference

Traceback (most recent call last):
  File "D:\a\videohash\videohash\setup.py", line 5, in <module>
    long_description = f.read()
  File "C:\hostedtoolcache\windows\Python\3.9.9\x64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 196[8](https://github.com/akamhy/videohash/runs/5096340174?check_suite_focus=true#step:5:8): character maps to <undefined>
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants