Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 support #245

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Python 3.12 support #245

merged 3 commits into from
Jul 28, 2024

Conversation

akanz1
Copy link
Owner

@akanz1 akanz1 commented Jul 28, 2024

Summary by Sourcery

This pull request adds support for Python 3.12 by including it in the CI workflow matrix, ensuring the project is tested against the latest Python version.

  • CI:
    • Added Python 3.12 to the CI workflow matrix for testing on Ubuntu, macOS, and Windows platforms.

@akanz1 akanz1 linked an issue Jul 28, 2024 that may be closed by this pull request
Copy link
Contributor

sourcery-ai bot commented Jul 28, 2024

Reviewer's Guide by Sourcery

This pull request adds support for Python 3.12 by updating the GitHub Actions workflow configuration to include Python 3.12 in the testing matrix.

File-Level Changes

Files Changes
.github/workflows/pythonpackage.yml Updated the GitHub Actions workflow to include Python 3.12 in the testing matrix.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @akanz1 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

sonarcloud bot commented Jul 28, 2024

@akanz1 akanz1 self-assigned this Jul 28, 2024
@akanz1 akanz1 merged commit b9c9a71 into main Jul 28, 2024
17 checks passed
@akanz1 akanz1 deleted the 244-feature-draft-release-to-support-312 branch July 28, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Draft release to support 3.12
1 participant