Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep for release 1.0.6 #74

Merged
merged 3 commits into from
Nov 12, 2022
Merged

prep for release 1.0.6 #74

merged 3 commits into from
Nov 12, 2022

Conversation

akanz1
Copy link
Owner

@akanz1 akanz1 commented Nov 12, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 12, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.46%.

Quality metrics Before After Change
Complexity 7.81 ⭐ 7.69 ⭐ -0.12 👍
Method Length 237.11 ⛔ 240.83 ⛔ 3.72 👎
Working memory 13.75 😞 13.57 😞 -0.18 👍
Quality 42.32% 😞 42.78% 😞 0.46% 👍
Other metrics Before After Change
Lines 1088 1103 15
Changed files Quality Before Quality After Quality Change
src/klib/_version.py 100.00% ⭐ 100.00% ⭐ 0.00%
src/klib/describe.py 31.99% 😞 31.91% 😞 -0.08% 👎
tests/test_clean.py 72.78% 🙂 72.34% 🙂 -0.44% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/klib/describe.py cat_plot 17 🙂 672 ⛔ 21 ⛔ 21.30% ⛔ Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py missingval_plot 6 ⭐ 822 ⛔ 19 ⛔ 32.20% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py dist_plot 9 🙂 798 ⛔ 15 😞 33.10% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py corr_plot 2 ⭐ 270 ⛔ 22 ⛔ 38.99% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py corr_mat 8 ⭐ 205 ⛔ 50.68% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #74 (aa60883) into main (d6d9480) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   53.54%   53.97%   +0.43%     
==========================================
  Files           3        3              
  Lines         465      465              
  Branches       63       63              
==========================================
+ Hits          249      251       +2     
+ Misses        209      208       -1     
+ Partials        7        6       -1     
Impacted Files Coverage Δ
src/klib/describe.py 19.74% <100.00%> (ø)
src/klib/utils.py 95.78% <0.00%> (+2.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akanz1 akanz1 changed the title Akanz1/issue72 prep for release 1.0.6 Nov 12, 2022
@akanz1 akanz1 merged commit f798e61 into main Nov 12, 2022
@akanz1 akanz1 deleted the akanz1/issue72 branch November 12, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant