Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output message startup #317

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Output message startup #317

merged 4 commits into from
Aug 1, 2024

Conversation

ShinobuTakahashi
Copy link
Contributor

概要

起動時に akashic-cli を利用するメッセージを出力します。

index.js Outdated
@@ -90,6 +90,7 @@ exports.run = (argv) => {
debug("Listening on " + bind);
}

console.log("[warn] akashic-sandbox has been merged into akashic-cli. Please use akashic-cli.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 内容的に console.warn() の方が自然そうです。
  • cli のバージョン明記したいです。
  • コマンド明記したいです。 Use `akashic sandbox` command (without '-'). でどうでしょう

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。メッセージ等修正しました。

@ShinobuTakahashi ShinobuTakahashi merged commit 345b128 into main Aug 1, 2024
12 checks passed
@ShinobuTakahashi ShinobuTakahashi deleted the output-message-startup branch August 1, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants