Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exeptions for unprocessable *.php files: #42

Merged
merged 4 commits into from
Oct 16, 2018

Conversation

gplanchat
Copy link
Contributor

The whole process breaks when:

  • no class is declared in the file
  • no namespace declaration is present in the file (eg. src/AppKernel.php on Sf 3.3+)

* no class is declared
* no namespace is present (eg. src/AppKernel.php on Sf 3.3+)
@gplanchat
Copy link
Contributor Author

gplanchat commented Oct 2, 2018

I just seen #34, it's not exactly a duplicate

In conclusion, we definitely need to either:
a. ignore the unprocessable files
b. push a friendly warning message for unprocessable files

And... I don't use it for Akeneo, so projects happens to have non-class/non-namespaced PHP files (and it fixes #41)

@gplanchat gplanchat changed the title Fixed exections for unprocessable *.php files: Fixed exeptions for unprocessable *.php files: Oct 2, 2018
@jjanvier
Copy link
Contributor

Hello @gplanchat

I didn't see your PR sorry (I don't know why I'm not notified).

I was thinking about an elegant way to solve this issue. I'll merge your PR so that you can continue to work normally. But for that I need the build to be green ^^
I'll try to find a "better design" later.

Thanks!

@jjanvier
Copy link
Contributor

OK, the build is broken because of a PHPStan update. Let's merge.
Thanks @gplanchat :)

@jjanvier jjanvier merged commit eab1b7d into akeneo:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants