CXP-1300: Adds first product meta schema #17982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willy-ahva
reviewed
Sep 21, 2022
components/catalogs/back/src/Infrastructure/Symfony/Resources/schemas/product-0.0.1.json
Outdated
Show resolved
Hide resolved
components/catalogs/back/src/Infrastructure/Validation/ProductSchemaValidator.php
Show resolved
Hide resolved
RiffVentura
reviewed
Sep 22, 2022
components/catalogs/back/src/Infrastructure/Symfony/Resources/schemas/product-0.0.1.json
Outdated
Show resolved
Hide resolved
RiffVentura
approved these changes
Sep 22, 2022
|
don't forget to link the API docs PR to fulfill the ticket |
masacc
approved these changes
Sep 23, 2022
willy-ahva
approved these changes
Sep 27, 2022
| @@ -56,7 +56,7 @@ public function validSchemaDataProvider(): array | |||
| { | |||
| return [ | |||
| '0.0.1 with valid schema' => [ | |||
| 'schema' => <<<'JSON' | |||
| 'schema' => <<<'JSON_WRAP' | |||
There was a problem hiding this comment.
Could you explain the diff pls?
There was a problem hiding this comment.
Rector complained about it.
https://github.com/rectorphp/rector/blob/main/rules/Php73/Rector/String_/SensitiveHereNowDocRector.php
I'm not sure why this rule exists.
Either we don't care and uses _WRAP or we disable the rule.
WDYT ?
RiffVentura
approved these changes
Sep 28, 2022
Beninho
pushed a commit
that referenced
this pull request
Sep 30, 2022
* CXP-1300: Adds first product meta schema * CXP-1300: remove & from schema * CXP-1300: fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why a new dependency ?
The current JSON Schema library we use in the PIM stopped updating the spec at the Draft-4. It does not support all the features we have in the meta schema.
jsonrainbow/json-schema#658 🎉
2 new alternatives emerged in the community, and after trying both, I went with
opis/json-schemabecause the API is similar and it supportsdraft-2020-12, draft-2019-09, draft-07 and draft-06.yes, we need an ADR.
Definition Of Done (for Core Developer only)