-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix typos #1
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe recent changes involve updates to various Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
crates/rpc-types-eth/src/transaction/request.rs (1)
316-316
: Fix typo in documentation commentThere's a typo in the documentation: "Returns and error" should be "Returns an error"
- /// Returns and error if required fields are missing. Use `complete_1559` to check if the + /// Returns an error if required fields are missing. Use `complete_1559` to check if theCHANGELOG.md (2)
127-127
: Fix markdown list formatting.The list item is missing proper spacing after the hyphen which affects markdown rendering.
-Modify ReceiptWithBloom and associated impls to use with Reth ([#1672](https://github.com/alloy-rs/alloy/issues/1672)) +- Modify ReceiptWithBloom and associated impls to use with Reth ([#1672](https://github.com/alloy-rs/alloy/issues/1672))
1235-1235
: Remove stray line numbers from changelog.There are several stray line numbers (1235, 1314, 1370, 1452, 1453, 1584) that appear to be artifacts and should be removed to maintain changelog readability.
Also applies to: 1314-1314, 1370-1370, 1452-1452, 1453-1453, 1584-1584
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (21)
CHANGELOG.md
(6 hunks)crates/alloy/CHANGELOG.md
(1 hunks)crates/consensus-any/CHANGELOG.md
(1 hunks)crates/consensus-any/src/block/header.rs
(1 hunks)crates/consensus/CHANGELOG.md
(1 hunks)crates/consensus/src/block/header.rs
(1 hunks)crates/consensus/src/receipt/mod.rs
(1 hunks)crates/consensus/src/receipt/receipts.rs
(1 hunks)crates/consensus/src/transaction/eip4844.rs
(1 hunks)crates/contract/CHANGELOG.md
(1 hunks)crates/contract/src/error.rs
(1 hunks)crates/json-rpc/CHANGELOG.md
(1 hunks)crates/network/src/any/mod.rs
(1 hunks)crates/provider/CHANGELOG.md
(1 hunks)crates/provider/src/heart.rs
(1 hunks)crates/provider/src/provider/with_block.rs
(1 hunks)crates/rpc-types-any/CHANGELOG.md
(1 hunks)crates/rpc-types-eth/CHANGELOG.md
(1 hunks)crates/rpc-types-eth/src/block.rs
(1 hunks)crates/rpc-types-eth/src/transaction/request.rs
(2 hunks)crates/transport-http/src/layers/auth.rs
(1 hunks)
🔥 Files not summarized due to errors (1)
- crates/rpc-types-eth/src/transaction/request.rs: Error: Server error: no LLM provider could handle the message
✅ Files skipped from review due to trivial changes (15)
- crates/contract/src/error.rs
- crates/provider/src/heart.rs
- crates/consensus-any/src/block/header.rs
- crates/consensus/src/receipt/mod.rs
- crates/network/src/any/mod.rs
- crates/consensus/src/receipt/receipts.rs
- crates/contract/CHANGELOG.md
- crates/consensus-any/CHANGELOG.md
- crates/json-rpc/CHANGELOG.md
- crates/provider/src/provider/with_block.rs
- crates/transport-http/src/layers/auth.rs
- crates/alloy/CHANGELOG.md
- crates/rpc-types-any/CHANGELOG.md
- crates/consensus/src/transaction/eip4844.rs
- crates/rpc-types-eth/src/block.rs
🔇 Additional comments (5)
crates/rpc-types-eth/src/transaction/request.rs (1)
665-665
: LGTM!
The documentation is clear and accurately describes the function's behavior and guarantees.
crates/consensus/src/block/header.rs (1)
622-622
: LGTM!
The documentation comment accurately describes the nonce
method.
crates/rpc-types-eth/CHANGELOG.md (1)
54-54
: LGTM!
The changelog entry clearly documents the modifications made to ReceiptWithBloom
and its associated implementations for use with Reth.
crates/provider/CHANGELOG.md (1)
405-405
: LGTM!
The changelog entry appropriately describes the improvements made to the alloy
prelude crate feature flag compatibility.
crates/consensus/CHANGELOG.md (1)
53-53
: LGTM!
The changelog entry accurately reflects the modifications to ReceiptWithBloom
and associated implementations.
Motivation
Solution
PR Checklist
Summary by CodeRabbit
New Features
typed2718
in transactions.Block
.BlockId
.Bug Fixes
asref
for receipts andfeeHistory
for estimating blob fees.Documentation
Chores