Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

New property HasUnevenRows to make the column height auto #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JimmyPun610
Copy link

Set HasUnevenRows to true on DataGrid will make the column height depends on the item inside

Copy link
Owner

@akgulebubekir akgulebubekir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for the feature implementation. It looks good. But there are 2 things you should do before approval

  • Indentation guideline: you should use tabs instead space for indentation.
  • Unit test : you should write unit test for this property

@@ -101,8 +101,14 @@ void HandleItemsSourceCollectionChanged(object sender, NotifyCollectionChangedEv
if (SelectedItem != null && !InternalItems.Contains(SelectedItem))
SelectedItem = null;
}

public static readonly BindableProperty RowHeightProperty =
public static readonly BindableProperty HasUnevenRowsProperty =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entire project uses tabs for indentation. Please follow the rule and convert spaces to tabs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants