Update to gulp 4. #915
Merged
Update to gulp 4. #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lydell
reviewed
May 5, 2018
gulpfile.coffee
Outdated
| @@ -122,30 +119,29 @@ gulp.task('install.rdf', -> | |||
| .pipe(gulp.dest(DEST)) | |||
| ) | |||
|
|
|||
| gulp.task('templates', [ | |||
| gulp.task('templates', gulp.series( | |||
There was a problem hiding this comment.
It can be if it works. Changed.
gulpfile.coffee
Outdated
| ) | ||
| )) | ||
|
|
||
| gulp.task('default', gulp.series(['push'])) |
There was a problem hiding this comment.
Is gulp.series supposed to be given an array here? The other gulp.series are not given arrays.
This fixes the build for recent versions of node.
|
What does this fix, and for what version of Node? |
|
It fixes this issue: nodejs/node#20285 All gulp commands were failing for me and I tried a number of things but upgrading gulp helped. My node version is: |
|
I tried to build VimFx today and gulp with node 10 failed with coredumps. I heard from others that node 10 had broken all their projects so I turned to an old node. |
|
@lilydjwg Does this patch fix it for you? |
|
@kevincox Yes, I just tried and it worked. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build for recent versions of node.