Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/center infinite false #1920

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vladbdev
Copy link

@vladbdev vladbdev commented Nov 4, 2020

I am currently working on a feature where I need the carousel to function like this:

  • center mode, infinite false, no empty placeholder
  • when user interacts with the carousel - click on next - set infinite true

In the current implementation there is a bug: if you set the initialSlide in the settings, it will break the arrow functionality for the first clicks on "next" - internally the slider starts targetSlide at 0, although the targetSlide should be populated from initialSlide - if provided.

Thank you,
Vlad

@thanhlmm
Copy link

Tested with my production site. Everything is Ok

@vladbdev
Copy link
Author

@akiran can you please take a look and trigger a travis CI rebuild as the last one failed due to node-sass?

Best
Vlad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants