-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi selection by click and drag #684
Add multi selection by click and drag #684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a segfault whenever I create an artboard and then select and empty area.
One thing that would be great to have is a live indicator of which items will be included in the selection.
Something like an "hover effect" around the items included in the selection area.
It could be done in a follow up PR.
Ok I fixed the issue in the last commit.
Yes, this would be nice. And I also think it should be done in another PR :) This should be ready to be merged! |
Summary / How this PR fixes the problem?
This PR handles click and drag multi selection, both inside artboard and outside (on freeitems).
It does create a new mode and a new ViewLayer.
Inside test is performed on item's bound. This needs to be completely included inside the selection bound.
Partial bound inclusion yields no selection.
Steps to Test
Screenshots
click_drag_multi_select.mp4
Known Issues / Things To Do