Skip to content

Commit

Permalink
Fixed the import module name issue
Browse files Browse the repository at this point in the history
CocoaPods/Core#205

Just learned from Facebook-iOS-SDK. Now cocoapods also supports module_name as well, so I added it too.
  • Loading branch information
Ono Masashi committed Mar 22, 2016
1 parent 145c531 commit 15fd982
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,7 @@
// Copyright © 2016年 akisute. All rights reserved.
//

// TODO: change the module name completely... I can't bare with this
// To confirm clang module system, we must not use - (dash) in the module name, which is replaced to _ (underscore).
// https://github.com/CocoaPods/Core/issues/205

// Doesn't work, needs umbrella header youtube-ios-player-helper.h, kinda ugly
//#import <youtube-ios-player-helper/youtube-ios-player-helper.h>

// Doesn't work because - is replaced to _ when clang module is enabled...
//#import <youtube-ios-player-helper/YTPlayerView.h>

// This one works but so ugly
#import <youtube_ios_player_helper/YTPlayerView.h>
#import <YTPlayerView/YTPlayerView.h>

#import "Sample_Basic_Code_ViewController.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2016年 akisute. All rights reserved.
//

#import <youtube_ios_player_helper/YTPlayerView.h>
#import <YTPlayerView/YTPlayerView.h>

#import "Sample_Basic_IB_ViewController.h"

Expand Down
2 changes: 2 additions & 0 deletions youtube-ios-player-helper.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,7 @@ Pod::Spec.new do |s|
# 'youtube-ios-player-helper' => ['Pod/Assets/*']
#}
s.public_header_files = 'Pod/Classes/**/*.h'
s.header_dir = 'YTPlayerView'
s.module_name = 'YTPlayerView'
s.frameworks = 'UIKit', 'WebKit'
end

0 comments on commit 15fd982

Please sign in to comment.