Skip to content

Commit

Permalink
Remove v8 redeclarations in v8go.h (rogchap#203)
Browse files Browse the repository at this point in the history
  • Loading branch information
dylanahsmith authored Oct 25, 2021
1 parent ed7ef69 commit e36a0b4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 14 deletions.
8 changes: 0 additions & 8 deletions v8go.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@
#include <string>
#include <vector>

#if defined(__MINGW32__) || defined(__MINGW64__)
// MinGW header files do not implicitly include windows.h
struct _EXCEPTION_POINTERS;
#endif

#include "libplatform/libplatform.h"
#include "v8.h"
#include "v8-profiler.h"
#include "_cgo_export.h"

using namespace v8;
Expand Down
14 changes: 8 additions & 6 deletions v8go.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
#define V8GO_H
#ifdef __cplusplus

namespace v8 {
class Isolate;
class CpuProfiler;
class CpuProfile;
class CpuProfileNode;
}
#if defined(__MINGW32__) || defined(__MINGW64__)
// MinGW header files do not implicitly include windows.h
struct _EXCEPTION_POINTERS;
#endif

#include "libplatform/libplatform.h"
#include "v8.h"
#include "v8-profiler.h"

typedef v8::Isolate* IsolatePtr;
typedef v8::CpuProfiler* CpuProfilerPtr;
Expand Down

0 comments on commit e36a0b4

Please sign in to comment.