Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiply protoPaths not compiling properly #686

Closed
Dr-Nikson opened this issue Sep 17, 2019 · 4 comments
Closed

Multiply protoPaths not compiling properly #686

Dr-Nikson opened this issue Sep 17, 2019 · 4 comments
Labels
help wanted Issues that the core team will likely not have time to work on maven
Milestone

Comments

@Dr-Nikson
Copy link

Versions used

Akka version: 2.5.22
akka-grpc-runtime: 0.7.1
akka-grpc-maven-plugin: 0.7.1

Expected Behavior

<protoPaths>
  <protoPath>src/main/proto</protoPath>
  <protoPath>../../protos/src/main/proto</protoPath>
</protoPaths>

I've configured two protoPaths and I'm expecting that plugin will look for all proto files before compilation starts. One of my protoPaths contains google prototobuf types, second protoPath contains my own protos based on the first ones.

Actual Behavior

Compilation fails because it can't find proto files from one path while compiling another:

google/protobuf/timestamp.proto: File not found.

@raboof
Copy link
Member

raboof commented Sep 23, 2019

Good observation! Would you be interested in trying to fix this and testing whether that works? It looks like in GenerateMojo.scala the list of paths should be passed into generate instead of calling generate for each path separately.

@raboof raboof added maven help wanted Issues that the core team will likely not have time to work on labels Sep 23, 2019
@jewertow
Copy link
Contributor

I could take care of this issue.

@Tochemey
Copy link

Hello, please what is the outcome of this issue. I am facing the same issue too

@jewertow
Copy link
Contributor

I'm working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that the core team will likely not have time to work on maven
Projects
None yet
Development

No branches or pull requests

5 participants