fix: protoPaths as import params to protoc (Maven) #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,10 +46,17 @@ public static CompletionStage<ServerBinding> run(ActorSystem sys) throws Excepti | |||
| // Instantiate implementation | |||
| GreeterService impl = new GreeterServiceImpl(mat); | |||
|
|
|||
| // Create the reflection handler for multiple services | |||
| Function<HttpRequest, CompletionStage<HttpResponse>> reflectionPartial = | |||
| ServerReflection.create(Arrays.asList(GreeterService.description), sys); | |||
There was a problem hiding this comment.
Not needed, but helped me to test locally.
| @@ -217,7 +217,7 @@ jobs: | |||
| - name: Test Maven Java | |||
| run: |- | |||
| cd plugin-tester-java | |||
| mvn -Dakka.grpc.project.version=`cat ~/.version` akka-grpc:generate compile | |||
There was a problem hiding this comment.
akka-grpc:generate should not be needed explicitly as it is already run bin compile (otherwise it would fail I assume).
johanandren
reviewed
Apr 13, 2023
johanandren
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
mvn, pass all items listed within<protoPaths>individually as-Itoprotoc.This allows to use protos from an artifact dependency in a maven build, like it is already supported for sbt and gradle.
Todo:
Fixes:
Took inspiration from here and provides a full working example of the workaround described.