Fixes. #917. Added include_std_type configuration option. #1136
Conversation
|
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged. For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask! |
There was a problem hiding this comment.
Thank you for looking into this!
The change mostly looks good to me, but the plugin-tester-java project now fails because it is also ran as part of the gradle/sbt builds, and this feature is not yet available there. Of course the 'best' way to fix this would be to implement this feature for sbt and gradle as well, but I can imagine that is beyond the scope of this PR. In that case we should perhaps remove comment out the changes to plugin-tester-java, and add tickets to fill in the gradle and sbt support before enabling the test?
dotbg
force-pushed
the
maven-plugin-options
branch
from
a54379e
to
36fb840
Compare
|
@raboof, I have fixed the gradle buld as well. The sbt looks like a tough one as I have to pass through the options to the sbt-protoc plugin. |
|
OK TO TEST |
Cool!
Actually you were already almost there - I took the liberty of amending your PR with the final bit. |
gradle-plugin/src/main/groovy/akka/grpc/gradle/AkkaGrpcPluginExtension.groovy
Outdated
Show resolved
Hide resolved
plugin-tester-java/src/main/java/example/myapp/helloworld/GreeterServer.java
Outdated
Show resolved
Hide resolved
raboof
force-pushed
the
maven-plugin-options
branch
from
8743e94
to
76ce3e9
Compare
sbt-plugin/src/sbt-test/gen-java/01-gen-basic-java/src/main/protobuf/helloworld.proto
Show resolved
Hide resolved
dotbg
force-pushed
the
maven-plugin-options
branch
from
76ce3e9
to
a85ac4a
Compare
+ Maven + Gradle + Sbt
dotbg
force-pushed
the
maven-plugin-options
branch
from
a85ac4a
to
2fcbed5
Compare
dotbg
force-pushed
the
maven-plugin-options
branch
2 times, most recently
from
00e84d4
to
ff48e93
Compare
cleanup + version alignment
dotbg
force-pushed
the
maven-plugin-options
branch
from
ff48e93
to
777f90d
Compare
raboof
force-pushed
the
maven-plugin-options
branch
2 times, most recently
from
e44cbdc
to
9c6ee53
Compare
raboof
force-pushed
the
maven-plugin-options
branch
from
9c6ee53
to
ab87b9a
Compare
Co-authored-by: Arnout Engelen <github@bzzt.net>
References #917