fix: allow messages with the same name from different packages #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes akka#1625 This allows messages with the same name but different packages to be used by the same service by prefixing the messages generated serializer names with the underscore separated package name if they came from if they come frome a different package to the package the service is declared in.
jroper
force-pushed
the
duplicate-message-names
branch
from
f45312e
to
ede312e
Compare
|
Could I get an akka-grpc release with this? I'm somewhat blocked on a customer issue until I can get this fix (I can work around it, but that will involve making breaking changes to a public API later when we want to move to the fix). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1625
This allows messages with the same name but different packages to be used by the same service by prefixing the messages generated serializer names with the underscore separated package name if they came from if they come frome a different package to the package the service is declared in.