build: Remove double 2.13 publish #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Oct 9, 2023
| @@ -29,7 +29,7 @@ jobs: | |||
| - name: Publish | |||
| run: |- | |||
| sbt +publishSigned | |||
| CI_RELEASE=akka-grpc-codegen/publishSigned CI_SNAPSHOT_RELEASE=akka-grpc-codegen/publish sbt ++2.13.10\! publishSigned | |||
| CI_RELEASE=akka-grpc-codegen/publishSigned CI_SNAPSHOT_RELEASE=akka-grpc-codegen/publish | |||
There was a problem hiding this comment.
I don't know the background of this, but could have been something with 2.12 and 2.13 cross publishing.
As far as I can see the above sbt +publishSigned will already publish for 2.13 and 3.
I don't know what that CI_RELEASE and CI_RELEASE is, but leaving that unchanged
There was a problem hiding this comment.
Looks like Raboof added that as a workaround for some publishing issues last year (#1400), not sure I understand why that is needed though.
johanandren
approved these changes
Oct 9, 2023
|
let's try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish fail in main: https://github.com/akka/akka-grpc/actions/runs/6453387739/job/17516874355