Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Build and publish scaladocs for runtime module #1868

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

johanandren
Copy link
Member

@johanandren johanandren commented Oct 31, 2023

We previously had to disable unidoc in #1847 because of the tricky build with 2.12 for plugins but 2.13 only for the runtime. This re-introduces at least scaladoc for the runtime module, published under akka-grpc/api/[version].

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

advanced, looking good

build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after one more wildcard?

build.sbt Outdated Show resolved Hide resolved
@johanandren johanandren merged commit 2372c62 into main Nov 1, 2023
12 checks passed
@johanandren johanandren deleted the wip-build-publish-runtime-scaladocs branch November 1, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants