-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Periodic client discovery refresh #1152 #1886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I know the request has been periodic refresh, but I wonder if there is a way to trigger a refresh programatically for a specific gRPC client? Let's say there is some external event (maybe something observed from Kubernetes) and the application would like to trigger a refresh immediately when seeing that event.
It is a bit hard to provide a regular programmatic hook since the Note that the refresh is in the client config so can be set separately for each specific endpoint via service name in config (or with code in the used |
@Marcus-Rosti @danieltahara how important is the ability to do a manual call if periodic refresh is in place with this PR? |
I think for our use case, manual isn't necessary, although I agree the ideal would be to have a trigger so it could just be directly synced to k8s events. |
c14fede
to
199e97a
Compare
f3362ec
to
9043dd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after some log minors
New per-service client config with an interval to trigger (possibly) cache-piercing refresh of discovered endpoints for a service.
Depends on upstream API addition in Akka.
References #1152