feat: Eager connect flag for Netty based client #1931
Conversation
Will casue the client creation to trigger connection to server rather than first on initial request, can help avoiding latency for the first requests caused by waiting for connection to complete.
| # Request that the client try to connect the service immediately when the client is created | ||
| # rather than on the first request. Only supported for the Netty client backend, the akka-http client backend | ||
| # is always eager. | ||
| eager-connection = off |
There was a problem hiding this comment.
Shall we add something to the client reference docs about this? Seems like something you want to enable most of the time.
There was a problem hiding this comment.
I'm not entirely sure it is something you want enabled most of the time, it since it would also means you might create a bunch of connections for clients that don't see any traffic so wastes resource usage (at least I'm guessing that is why it is lazy by default). For the record clients will also idle timeout after a default 5 minutes without any requests and switch to an "IDLE" state and only reconnect when a new request is made.
There was a problem hiding this comment.
Mentioning in docs seems good though.
There was a problem hiding this comment.
ok, yes we should not change the default
Co-authored-by: Enno Runne <458526+ennru@users.noreply.github.com>
Will cause the client creation to trigger connection to server rather than first on initial request, can help avoiding latency for the first requests caused by waiting for connection to complete.
References #1930