Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JavaUUID path matcher #2596

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Improve JavaUUID path matcher #2596

merged 1 commit into from
Jul 24, 2019

Conversation

Philippus
Copy link
Contributor

Purpose

Improve the JavaUUID path matcher

Changes

This PR tightens the existing regex and adds the nil uuid, making it accept uuid's as defined in RFC 4122. Also avoids a try/catch block.

@Philippus Philippus force-pushed the improve-java-uuid-path-matcher branch from 2fd53f9 to 618b465 Compare July 16, 2019 00:52
@Philippus Philippus changed the title Improve java UUID path matcher Improve JavaUUID path matcher Jul 16, 2019
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Jul 16, 2019
@akka-ci
Copy link

akka-ci commented Jul 16, 2019

Test PASSed.

jrudolph
jrudolph reviewed Jul 16, 2019
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional functionality looks good but might still make sense to keep the try/catch?

akka-http/src/main/scala/akka/http/scaladsl/server/PathMatcher.scala Show resolved Hide resolved
@Philippus Philippus force-pushed the improve-java-uuid-path-matcher branch from 618b465 to bb556d8 Compare July 23, 2019 16:50
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jul 23, 2019
@akka-ci
Copy link

akka-ci commented Jul 23, 2019

Test PASSed.

jrudolph
jrudolph approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really simple now, thanks @Philippus. LGTM

@jrudolph jrudolph merged commit 03dba93 into akka:master Jul 24, 2019
@jrudolph jrudolph added this to the 10.1.10 milestone Jul 24, 2019
@Philippus Philippus deleted the improve-java-uuid-path-matcher branch July 24, 2019 11:23
This was referenced Jul 31, 2019
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

@raboof raboof raboof approved these changes

@jrudolph jrudolph jrudolph approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@Philippus @akka-ci @jrudolph @raboof @johanandren