Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=core Make use of statefulMap instead of statefulMapConcat. #4302

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Aug 30, 2023

Motivation:
Change to use statefulMap instead when not concating.

@johanandren johanandren merged commit 11dcd46 into akka:main Aug 30, 2023
16 checks passed
@johanandren johanandren added this to the 10.6.0 milestone Aug 30, 2023
@He-Pin He-Pin deleted the statefulMap branch August 30, 2023 13:20
@He-Pin
Copy link
Member Author

He-Pin commented Aug 31, 2023

I ran a benchmark locally just now @johanandren :

[info] Do not assume the numbers tell you what you want them to tell.
[info] Benchmark                                                Mode  Cnt         Score        Error  Units
[info] MessageToFrameRendererBenchmark.benchNewStreamedFrames  thrpt   10  15148931.446 锟斤拷  99406.646  ops/s
[info] MessageToFrameRendererBenchmark.benchOldStreamedFrames  thrpt   10  13296638.654 锟斤拷 553890.759  ops/s

with

Jmh/run -i 10 -wi 10 -f1 -t1 .MessageToFrameRendererBenchmark.

And I think this is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants