Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for MS-SQL-server #108

Closed
wants to merge 6 commits into from

Conversation

naferx
Copy link
Contributor

@naferx naferx commented Jun 14, 2017

Ref #102

+ added docker image for testing
+ provided sql scripts
+ added example of configuration for Sql Server
@naferx
Copy link
Contributor Author

naferx commented Jun 19, 2017

Hi @dnvriend , How can I set up environment variables for MS SqlServer ?
Seems like Travis is hanging out for it

@dnvriend
Copy link
Contributor

@naferx AFAIK configuring Travis is something that only the account holder (me) can do, but I've added the environment vars. A question, I cannot find sqlserver support in the docs for Travis? Where did you find the configuration as you've edited travis.yml?

@naferx
Copy link
Contributor Author

naferx commented Jun 21, 2017

Oh sorry, I thought that editing the file, it could work. Let me a moment to revert that change

... to pull and run sqlserver docker image
@naferx
Copy link
Contributor Author

naferx commented Jul 29, 2017

I'm wondering why the tests didn't run 😕

[info] - should persist a single serializable message (785 milliseconds)
[info] - should not persist a single non-serializable message (516 milliseconds)
[info] - should persist only serializable messages (711 milliseconds)
[info] SqlServerStoreOnlySerializableMessagesTest:


No output has been received in the last 10m0s, this potentially indicates a 
stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on:
 https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

@WellingR
Copy link
Member

WellingR commented Aug 26, 2017

If I take a look at the readme on the slick github repo. Then you can see that the slick build for MS SQL server is actually built using Appveyor instead of travis.

We might need to investigate if we can set this up for the SQL server build

@naferx
Copy link
Contributor Author

naferx commented Aug 30, 2017

@WellingR , Thanks for the hint

I've been busy these days, hope to investigate how to do that setup on next weekend.

@WellingR
Copy link
Member

WellingR commented Oct 9, 2017

There seems to be a new docker release for sql server 2017. So it might be worth investigating if it possible to get this one to work with travis

@PerWiklander
Copy link

Is the status of this that we are waiting for working CI, while the actual feature is ready for use (more or less)?

@WellingR
Copy link
Member

WellingR commented Nov 8, 2017

@PerWiklander Assuming that the PR autor managed to run the tests locally, you are correct.
If you are actively waiting for this please contact us on gitter.

@naferx Are you still planning to continue working on this soon, or do you want some help?

@naferx
Copy link
Contributor Author

naferx commented Nov 8, 2017

@PerWiklander, I tested it locally based on https://github.com/akka/akka-samples/tree/2.5/akka-sample-persistence-scala

@WellingR, I was trying to setup appyevor on this repo test https://github.com/naferx/akka-persistence-jdbc-test, but don't have enough time. At this point, I have to let someone else continue

@octonato
Copy link
Member

@naferx are you still interesting in pursuing with this PR? It is now in conflict and we still need to sort out the build. Have you tried to get it running with a docker like @WellingR suggested? That might be the best option because all other tests are running with docker already and it's easier if we keep the build in Travis.

@naferx
Copy link
Contributor Author

naferx commented Apr 26, 2018 via email

@octonato
Copy link
Member

@naferx, I will be closing this for now. Nobody else in the community seems to have a need for it. If you don't delete your original branch, someone can maybe pickup from there or get inspiration from it.

Thanks for you efforts in any case.

@octonato octonato closed this May 29, 2018
@jonfox jonfox mentioned this pull request Sep 5, 2018
octonato pushed a commit that referenced this pull request Sep 19, 2018
Adds SQL Server schema and test updates. I created a derived SQL server [image](https://hub.docker.com/r/topaztechnology/mssql-server-linux/) that allows login and database creation on startup to facilitate testing.

Write performance was initially poor vs Postgres, but significantly improved with use of `transactionally` in  `BaseByteArrayJournalDao.writeJournalRows`

This was based on a closed PR #108, thanks to @naferx
evgenyzic pushed a commit to evgenyzic/akka-persistence-jdbc that referenced this pull request Dec 16, 2019
Adds SQL Server schema and test updates. I created a derived SQL server [image](https://hub.docker.com/r/topaztechnology/mssql-server-linux/) that allows login and database creation on startup to facilitate testing.

Write performance was initially poor vs Postgres, but significantly improved with use of `transactionally` in  `BaseByteArrayJournalDao.writeJournalRows`

This was based on a closed PR akka#108, thanks to @naferx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants