-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for MS-SQL-server #108
Conversation
+ added docker image for testing + provided sql scripts + added example of configuration for Sql Server
Hi @dnvriend , How can I set up environment variables for MS SqlServer ? |
@naferx AFAIK configuring Travis is something that only the account holder (me) can do, but I've added the environment vars. A question, I cannot find sqlserver support in the docs for Travis? Where did you find the configuration as you've edited travis.yml? |
Oh sorry, I thought that editing the file, it could work. Let me a moment to revert that change |
97dc272
to
3892fbd
Compare
... to pull and run sqlserver docker image
I'm wondering why the tests didn't run 😕
|
If I take a look at the readme on the slick github repo. Then you can see that the slick build for MS SQL server is actually built using Appveyor instead of travis. We might need to investigate if we can set this up for the SQL server build |
@WellingR , Thanks for the hint I've been busy these days, hope to investigate how to do that setup on next weekend. |
There seems to be a new docker release for sql server 2017. So it might be worth investigating if it possible to get this one to work with travis |
Is the status of this that we are waiting for working CI, while the actual feature is ready for use (more or less)? |
@PerWiklander Assuming that the PR autor managed to run the tests locally, you are correct. @naferx Are you still planning to continue working on this soon, or do you want some help? |
@PerWiklander, I tested it locally based on https://github.com/akka/akka-samples/tree/2.5/akka-sample-persistence-scala @WellingR, I was trying to setup appyevor on this repo test https://github.com/naferx/akka-persistence-jdbc-test, but don't have enough time. At this point, I have to let someone else continue |
@naferx are you still interesting in pursuing with this PR? It is now in conflict and we still need to sort out the build. Have you tried to get it running with a docker like @WellingR suggested? That might be the best option because all other tests are running with docker already and it's easier if we keep the build in Travis. |
Ohh, Sorry Renato,
Unfortunately, I don't have enough time to push it over the finish line.
I hope someone can continue my initial effort.
…On Thu, Apr 26, 2018 at 8:56 AM, Renato Cavalcanti ***@***.*** > wrote:
@naferx <https://github.com/naferx> are you still interesting in pursuing
with this PR? It is now in conflict and we still need to sort out the
build. Have you tried to get it running with a docker like @WellingR
<https://github.com/WellingR> suggested? That might be the best option
because all other tests are running with docker already and it's easier if
we keep the build in Travis.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALStTnc58GZWpGsB6-5dFisay-EN4ja-ks5tsdH8gaJpZM4N6jGZ>
.
|
@naferx, I will be closing this for now. Nobody else in the community seems to have a need for it. If you don't delete your original branch, someone can maybe pickup from there or get inspiration from it. Thanks for you efforts in any case. |
Adds SQL Server schema and test updates. I created a derived SQL server [image](https://hub.docker.com/r/topaztechnology/mssql-server-linux/) that allows login and database creation on startup to facilitate testing. Write performance was initially poor vs Postgres, but significantly improved with use of `transactionally` in `BaseByteArrayJournalDao.writeJournalRows` This was based on a closed PR #108, thanks to @naferx
Adds SQL Server schema and test updates. I created a derived SQL server [image](https://hub.docker.com/r/topaztechnology/mssql-server-linux/) that allows login and database creation on startup to facilitate testing. Write performance was initially poor vs Postgres, but significantly improved with use of `transactionally` in `BaseByteArrayJournalDao.writeJournalRows` This was based on a closed PR akka#108, thanks to @naferx
Ref #102