Documentation fixes #197
Merged
Documentation fixes #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
WellingR
commented
Sep 1, 2018
WellingR
commented
- Fixed a mistake in the configuration example for custom database providers
- Improved documentation on thread/connection pool sizing (specifically by removing the vague 5 * number of cores recommendation and pointing to a better resource)
octonato
reviewed
Sep 3, 2018
| @@ -98,13 +97,10 @@ akka-persistence-jdbc { | |||
| # ensures that the database does not get dropped while we are using it | |||
| keepAliveConnection = on | |||
|
|
|||
| # 5 * number of cores | |||
| # See some tips on thread/connection pool sizing on https://github.com/brettwooldridge/HikariCP/wiki/About-Pool-Sizing | |||
| # Keep in mind that the number of threads must equal the maximum number of connections. | |||
There was a problem hiding this comment.
we should eventually deprecate it and only have maxConnections. Not something to do right now, though
octonato
approved these changes
Sep 3, 2018
evgenyzic
pushed a commit
to evgenyzic/akka-persistence-jdbc
that referenced
this pull request
Dec 16, 2019
- Fixed a mistake in the configuration example for custom database providers - Improved documentation on thread/connection pool sizing (specifically by removing the vague 5 * number of cores recommendation and pointing to a better resource)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.